feat: drop rule groups Ruff 0.16 selects by default - #843
Merged
Conversation
Ruff 0.16 enables 413 rules without configuration. `BLE`, `DTZ`, `FA`, `FLY`, `INT`, `PIE`, and `YTT` are fully covered, and `I` is covered except for `I002`, which needs the `required-imports` setting. Remove these from the cookie and the style guide, remove the `RF102` check, and teach `sp-ruff-checks` to report them as safe to remove instead of suggesting them. Assisted-by: ClaudeCode:claude-opus-5
Collaborator
Author
|
Here's the B and UP rules that are not selected by default still: 🤖 AI text below 🤖 Checked against ruff 0.16.2 (
Stable rules you only get by selecting
Preview-only, so selecting
Stable gains: UP013 (convert-typed-dict-functional-to-class), UP015 (redundant-open-modes), UP042 (replace-str-enum). |
Ruff 0.16 selects 42 of the 48 `UP` rules without configuration. Selecting the group is still useful for the three stable rules it adds (`UP013`, `UP015`, and `UP042`), so keep the suggestion in the style guide and in `sp-ruff-checks`, but stop reporting it as a required setting. Assisted-by: ClaudeCode:claude-opus-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Ruff 0.16 turns on 413 rules without configuration. Compared the default set against the full rule index:
BLE,DTZ,FA,FLY,INT,PIE, andYTTare fully covered (including preview rules), andIis covered except forI002, which needs thelint.isort.required-importssetting. No other group is fully covered.extend-selectand from both example configs in the style guide.RF102check ("isort must be selected").RF101(B) andRF103(UP) stay, because those groups are not fully default.sp-ruff-checksno longer suggests the default groups under "Unselected". If a config still selects one, it is now listed under "Selected, but on by default (safe to remove)".linter.jsonis unchanged: Ruff 0.16 adds and removes no linter prefixes.📚 Documentation preview 📚: https://scientific-python-cookie--843.org.readthedocs.build/